Navigation path

Additional tools

STORK

(
 
)
Editor's choice
68 reads

SAML engine's public method's exception handling

Change the SAML Engine's public method signatures to declare a SAML-Engine specific exception instead of the generic Exception they are currently declaring. e.g. for the method generateSTORKAuthnRequest this could be: AuthRequestGenerationException.

Hardware All
Product SAML engine
Operating System All
Component SAML engine
Version None
Severity normal
Resolution Fixed

Attachment

Information

Project:
STORK
Category:
Bugs
Priority:
Major
Assigned:
jheppe
Status:
Closed
Identifier:
32682

Comments

John Heppe
Posted by John Heppe on January 14, 2010 at 13:32
Title:SAML engine's public method's exception handling» <p>Is there any
Project:» STORK
Category:» Bugs
Priority:» Major
Assigned to:former user» jheppe
Status:» Closed

Is there any good reason to substitute a generic exception by another generic exception?

John Heppe
Posted by John Heppe on January 14, 2010 at 13:33

Is there any reason to request the substitution of a generic exception by anothe rgeneric exception?

Former User
Posted by Former User on January 18, 2010 at 13:29
Title:<p>Is there any» <p>The way

The way exceptions are currently defined, the application is forced to catch all exceptions (including run-time exceptions) in order to catch an application-level one, because the Java signature of the exception is the "generic" one ("generic" is to be understood here as a Java technical term). We should keep exactly the same exception handling (from a functional point of view), but replace the "Exception" type by an application-level one - which could be totally generic from a functional point of view, like "SAMLException" - to not mix application-level exception with system-level ones. Furthermore, the SAML engine should not catch run-time exceptions, but only application-level ones.